WIP - pkg/flock package #378
Conversation
| // synchronized by the caller. | ||
| func (f *flock) open() error { | ||
| if f.fd != -1 || f.flockType != flockUnlocked { | ||
| return fmt.Errorf("%v: trying to open improper Flock %q %d %d", errInternal, f.path, f.fd, f.flockType) |
There was a problem hiding this comment.
Initially I had that but the problem is that Wrapf mixes the order. I want to have a "internal error ..." but using Wrapf would move that to the end.
Introduce the pkg/flock package, a flock(2)-based implementation in golang that can be used within and across process spaces. The main motivation for this package is to benefit from the TryLock-semantics offered by flock(2), which is not possible with c/storage.Locker file lock since they are based on fcntl(2). Signed-off-by: Valentin Rothberg <[email protected]>
|
Marking it as WIP until there's a user of this API, presumably the copy-blob-detection in c/image. |
| // New returns a Flock for path. | ||
| func New(path string) (flock, error) { | ||
| // Make sure we can operate on the path. | ||
| fd, err := unix.Open(path, os.O_RDWR|os.O_CREATE, unix.S_IRUSR|unix.S_IWUSR) |
There was a problem hiding this comment.
Should we use an unix.Access check for this rather then opening and closing? Would that be faster? And then only create the file if it does not exists.
|
@nalind WDYT? |
| @@ -0,0 +1,63 @@ | |||
| // flock exposes an API around flock(2) but allows for synchronizing within and | |||
| // across process spaces, making it suitable for currently running threads and | |||
There was a problem hiding this comment.
s/currently/concurrently/
|
@vrothberg Makes sense, since I envisioned @nalind Blocking this if it was not used in containers/storage. |
|
@vrothberg Lets talk about this in the next meeting. |
|
Ping. @rhatdan, let's check if we still/really need this PR. |
|
@vrothberg Needs a rebase. New conversations with @saschagrunert might get us a user for this, yet. |
|
@rhatdan, I prefer to wait until we're certain there will be a user. |
|
@vrothberg Since this has been around for 2+ years, can we close it? |
|
Actually over 3 years. Time flies by! |
Introduce the pkg/flock package, a flock(2)-based implementation in
golang that can be used within and across process spaces. The main
motivation for this package is to benefit from the TryLock-semantics
offered by flock(2), which is not possible with c/storage.Locker file
lock since they are based on fcntl(2).
Signed-off-by: Valentin Rothberg [email protected]