Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SafeChown when ContainersOverrideXattr is unset #2197

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Dec 12, 2024

This happens e.g. in idtools.MkdirAllAndChownNew .

@giuseppe PTAL, this is necessary for c/image tests on macOS.

This happens e.g. in idtools.MkdirAllAndChownNew .

Signed-off-by: Miloslav Trmač <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 61d637b into containers:main Dec 13, 2024
20 checks passed
@mtrmac mtrmac deleted the missing-xattr branch December 13, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants