Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old +build tags, add gofix ci job #2101

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Sep 19, 2024

  1. Remove old-style +build tags (via go fix)
  2. Add a CI job to ensure go fix would not change anything

Brought to you by

	go fix ./...

Signed-off-by: Kir Kolyshkin <[email protected]>
Ensure that running `go fix` would not change anything.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin changed the title [test] .cirrus.yml: add gofix job Remove old +build tags, add gofix ci job Sep 20, 2024
@kolyshkin kolyshkin marked this pull request as ready for review September 20, 2024 21:56
@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2024

/approve
LGTM

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2024

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, kolyshkin, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ebd463a into containers:main Sep 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants