Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare a golangci-lint installation for automatic update using renovate #2064

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Prepare a golangci-lint installation for automatic update using renovate #2064

merged 1 commit into from
Aug 19, 2024

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Aug 16, 2024 •
edited
Loading

This PR prepares the golangci-lint installation for automatic update by renovate.

Depends on:

@Honny1 Honny1 force-pushed the golangci-lint-renovate branch from 1c41883 to 59f926e Compare August 16, 2024 14:25
@Honny1 Honny1 marked this pull request as ready for review August 16, 2024 14:30
@rhatdan
Copy link
Member

rhatdan commented Aug 16, 2024

/approve
LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mtrmac
mtrmac reviewed Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall.

tests/tools/Makefile Outdated Show resolved Hide resolved
@Honny1 Honny1 force-pushed the golangci-lint-renovate branch from 59f926e to 52828e9 Compare August 19, 2024 09:14
@Honny1 Honny1 requested a review from mtrmac August 19, 2024 09:15
mtrmac
mtrmac reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test output,

fatal: Not a valid object name main

I think that’s unrelated and it comes from hack/git-validation.sh; can you double-check, please? If so, that seems worth at least filing an issue.

@Honny1
Copy link
Member Author

Honny1 commented Aug 19, 2024 •
edited
Loading

Yes, it comes from hack/git-validation.sh. I created an issue: #2067

@Honny1 Honny1 force-pushed the golangci-lint-renovate branch from 45a0912 to 52828e9 Compare August 19, 2024 11:53
mtrmac
mtrmac reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for checking!

@openshift-ci openshift-ci bot added the lgtm label Aug 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2944d5b into containers:main Aug 19, 2024
18 checks passed
@edsantiago edsantiago mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees

@mtrmac mtrmac

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honny1 @rhatdan @mtrmac