Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked: do not write cache file to RO store #2031

Conversation

giuseppe
Copy link
Member

if the layer is R/O, do not write a cache file.

if the layer is R/O, do not write a cache file.

Signed-off-by: Giuseppe Scrivano <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@giuseppe
Copy link
Member Author

@rhatdan @mtrmac an easy one, but it solves an annoying warning when using an additional image store

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t this effectively completely stop looking for files in the read-only layers? It doesn’t stop writing the cache, it stops also creating it. And without an entry in c.layers, there can be no matches found in that layer.

*shrug* I don’t have a strong opinion on impact of that — avoiding cross-store linking might well be a good idea — but I’d like at least the comment in the code to be correct about the impact.

(And, ideally, the various implications of ALS/AIS, especially WRT cross-store sharing and dependencies, would be documented in detail somewhere, but I can see an argument that that’s not this PR.)

@rhatdan
Copy link
Member

rhatdan commented Jul 16, 2024

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6ddf982 into containers:main Jul 22, 2024
18 checks passed
mtrmac added a commit to mtrmac/storage that referenced this pull request Aug 30, 2024
A follow-up to containers#2031 .

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac
Copy link
Collaborator

mtrmac commented Aug 30, 2024

I’d like at least the comment in the code to be correct about the impact.

#2079 .

mtrmac added a commit to mtrmac/storage that referenced this pull request Sep 3, 2024
A follow-up to containers#2031 .

Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants