store: drop remap-[ug]ids #1976
Conversation
giuseppe
force-pushed
the
drop-remap-user
branch
3 times, most recently
from
879b393 to
f300410
Compare
|
Right, there's no good use case for setting this globally now AFAIK. While this obviously isn't exhaustive, at least a Github code search doesn't turn up any obvious uses of this in the wild. (There are a lot of copies of the default...including some from people who are obviously committing the defaults that we write into their home directory into git...which wouldn't exist if we didn't write the defaults into a file at all) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Would be good to fire off a podman test suite against this change. |
giuseppe
force-pushed
the
drop-remap-user
branch
from
f300410 to
a782176
Compare
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
drop the possibility to configure a remapping for all the layers in the storage. The feature dates back to the initial fork from Docker, that supported a single user namespace where all the images were pulled. It was never used by the container tools since we have a finer control of the user namespaces. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
drop-remap-user
branch
from
a782176 to
2d959dd
Compare
giuseppe
changed the title
|
tests passed. Ready for review |
|
/lgtm |
drop the possibility to configure a remapping for all the layers in the storage.
The feature dates back to the initial fork from Docker, that supported a single user namespace where all the images were pulled. It was never used by the container tools since we have a finer control of the user namespaces.