Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings (SA9003, SA4023, SA1019) #1973

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Jun 18, 2024

This PR fixes warnings (SA9003, SA4023, SA1019) found by golangci when the staticcheck linter is enabled.

Partially fixes:

lockfile_compat.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code LGTM.

I especially appreciate having one commit per idea clearly separated.

Please squash the “Fix ignore of Using a deprecated function, variable, constant or field (SA1019)” and “Improve explanation of ignore deprecated code” commits; we don’t need both in the permanent history — and besides, it will serve as a practical example of git rebase -i.

…d (SA1019)

Signed-off-by: Jan Rodák <[email protected]>

Improve explanation of ignore deprecated code

Signed-off-by: Jan Rodák <[email protected]>
@Honny1
Copy link
Member Author

Honny1 commented Jun 19, 2024

@mtrmac I have quashed commits.

@mtrmac
Copy link
Collaborator

mtrmac commented Jun 19, 2024

/lgtm
/approve

Thanks!

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c7bff71 into containers:main Jun 19, 2024
18 checks passed
@Honny1 Honny1 deleted the fix-warnings branch July 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants