-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings (SA9003, SA4023, SA1019) #1973
Conversation
Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Code LGTM.
I especially appreciate having one commit per idea clearly separated.
Please squash the “Fix ignore of Using a deprecated function, variable, constant or field (SA1019)” and “Improve explanation of ignore deprecated code” commits; we don’t need both in the permanent history — and besides, it will serve as a practical example of git rebase -i
.
…d (SA1019) Signed-off-by: Jan Rodák <[email protected]> Improve explanation of ignore deprecated code Signed-off-by: Jan Rodák <[email protected]>
@mtrmac I have quashed commits. |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes warnings (SA9003, SA4023, SA1019) found by
golangci
when thestaticcheck
linter is enabled.Partially fixes: