chunked: fix deadlock by always consuming tar-split #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
giuseppe
force-pushed
the
always-consume-tar-split-data
branch
from
4c83cec to
b5d73d0
Compare
mtrmac
reviewed
Jun 3, 2024
always consume the tar-split data when present to avoid blocking the producer. Previously, the tar-split data was only read when the digest was specified. commit 6875c9f introduced the regression. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
always-consume-tar-split-data
branch
from
b5d73d0 to
4595fa2
Compare
|
/lgtm |
|
/cherrypick release-1.54 |
|
@giuseppe: new pull request created: #1945 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always consume the tar-split data when present to avoid blocking the producer. Previously, the tar-split data was only read when the digest was specified.
commit 6875c9f introduced the regression.
follow-up for: #1936 (comment)