Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.45] quota: unlink tmp file before creating it #1710

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[release-1.45] quota: unlink tmp file before creating it #1710

merged 3 commits into from
Sep 14, 2023

Conversation

TomSweeneyRedHat
Copy link
Member

Before creating the tmp file, we unlink it first to avoid an EEXIST
error.

Cherry Pick of befd147
Needed for Podman v4.4.1 backport.

Fixes: https://issues.redhat.com/browse/RHEL-3163

Also bump the version in this branch to v1.45.6, then back to 1.45.7-dev

[NO NEW TESTS NEEDED]

giuseppe and others added 3 commits September 12, 2023 17:33
@giuseppe @TomSweeneyRedHat
[release-1.45] quota: unlink tmp file before creating it
e7f5808 
Before creating the tmp file, we unlink it first to avoid an EEXIST
error.

Cherry Pick of containers@befd147
Needed for Podman v4.4.1 backport.

Fixes: https://issues.redhat.com/browse/RHEL-3163

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: TomSweeneyRedHat <[email protected]>
@TomSweeneyRedHat
[release-1.45] Bump to v1.45.6
b156de2 
As the title says.  Bumping for a backport.
[NO NEW TESTS NEEDED]

Signed-off-by: TomSweeneyRedHat <[email protected]>
@TomSweeneyRedHat
[release-1.45] Bump to v1.45.7-dev
a3b0bfa 
As the title says

[NO NEW TESTS NEEDED]

Signed-off-by: TomSweeneyRedHat <[email protected]>
@TomSweeneyRedHat
Copy link
Member Author

@vrothberg and @mtrmac PTAL

@TomSweeneyRedHat
Copy link
Member Author

@giuseppe PTAL

giuseppe
giuseppe approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: giuseppe, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member Author

The test failure is lint not being able to find something in a Debian repo?

@TomSweeneyRedHat
Copy link
Member Author

@cevich any idea where the lint failure from Debian is coming from?

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 13, 2023

(Backport LGTM.)

I think the difference is c0c43e4 on main. I didn’t look into whether doing that is appropriate for a release branch, or whether we need to something else to preserve an older environment.

@TomSweeneyRedHat
Copy link
Member Author

Per @cevich the test failure is expected in this branch

@TomSweeneyRedHat
Copy link
Member Author

Created WIP test PR in Podman: containers/podman#19971

@TomSweeneyRedHat
Copy link
Member Author

WIP test on Podman "fails", but fails in a test for "fedora-37-aarch64 rootless host" like other PR's in that branch fail. @rhatdan, or @nalind, are you comfortable using the merge hammer on this?

@rhatdan rhatdan merged commit e52057c into containers:release-1.45 Sep 14, 2023
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/unlinkcherry branch November 16, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomSweeneyRedHat @mtrmac @giuseppe @rhatdan