[main] Recreate missing backingFsBlockDev on setting xfs project quota #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
reviewed
Sep 8, 2022
saschagrunert
force-pushed
the
recreate-backingFsBlockDev
branch
from
b17adb7 to
2e79f8d
Compare
|
LGTM |
|
@saschagrunert Whats up with this one? |
The QA needs to verify that it works with CRI-O (see https://issues.redhat.com/browse/OCPBUGS-773) |
saschagrunert
changed the title
saschagrunert
force-pushed
the
recreate-backingFsBlockDev
branch
4 times, most recently
from
86caf99 to
e1eaada
Compare
There is the rare case that something removed the backingFsBlockDev, which usually points to `/var/lib/containers/storage/overlay/backingFsBlockDev`. In that case, all `SetQuota` operations would fail on overlay layer creation. We now work around that error by recreating the backingFsBlockDev. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
recreate-backingFsBlockDev
branch
from
e1eaada to
aa0d394
Compare
|
Manually verified that the patch works with CRI-O. Ready for review @rhatdan. |
|
LGTM |
This was referenced Nov 22, 2022
This was referenced Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the rare case that something removed the backingFsBlockDev, which usually points to
/var/lib/containers/storage/overlay/backingFsBlockDev. In that case, allSetQuotaoperations would fail on overlay layer creation.We now work around that error by recreating the backingFsBlockDev.
/hold
I have to test this on CRI-O and rebase the change to c/storage v1.37.0
Refers to #1326