[v1.38, backport] store: add independent AddNames and RemoveNames for images,layers,containers
#1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainers Adds AddNames and RemoveNames so operations which are invoked in parallel manner can use it without destroying names from storage. For instance We are deleting names which were already written in store. This creates faulty behavior when builds are invoked in parallel manner, as this removes names for other builds. To fix this behavior we must append to already written names and override if needed. But this should be optional and not break public API Following patch will be used by parallel operations at podman or buildah end, directly or indirectly. Signed-off-by: Aditya R <[email protected]>
Signed-off-by: Aditya R <[email protected]>
|
LGTM |
|
nvm its already here: https://github.com/containers/storage/tree/v1.38.3 |
|
Partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 and https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
|
Exceptions approved: RHEL 9.0 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 RHEL 8.6 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1153
Adds AddNames and RemoveNames so operations which are invoked in parallel
manner can use it without destroying names from storage.
For instance
We are deleting names which were already written in store.
This creates faulty behavior when builds are invoked in parallel manner, as
this removes names for other builds.
To fix this behavior we must append to already written names and
override if needed. But this should be optional and not break public API
Following patch will be used by parallel operations at podman or buildah end, directly or indirectly.