image, layers, container: append new names to the ones which were written before and dedupe
#1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tten We are deleting names which were already written in store. This creates faulty behviour when builds are invoked in parallel manner, as this removes names for other builds. To fix this behviour we must append to already written names and override if needed. Following patch fixes concurrent builds via podman or buildah. Signed-off-by: Aditya R <[email protected]>
|
I think we need a new function to expose the functionality, otherwise it is a breaking change. Maybe |
|
Yes, This is breaking change, this PR must be replaced with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are deleting names which were already written in store.
This creates faulty behavior when builds are invoked in parallel manner, as
this removes names for other builds.
To fix this behavior we must append to already written names and
override if needed.
Following patch fixes concurrent builds via podman or buildah.
See: containers/buildah#3794 for more details.