drivers, chown: support chown of hard links #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a preparatory commit. Signed-off-by: Giuseppe Scrivano <[email protected]>
make sure the same inode is not chowned twice. Track all the inodes that are chowned and skip the same inode if it is encountered multiple times. Closes: containers#1143 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
chown-skip-hard-links
branch
from
ab2089b to
f59aa7a
Compare
|
LGTM |
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jun 13, 2022
Add an additional check before deciding whether the chown must be skipped. If the underlying storage (as it could be overlay with index=off) breaks the hard link on copy up then we cannot skip the chown even if the dev/ino was already encountered. containers#1144 added the initial check. Closes: containers#1257 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jun 13, 2022
If the inode was already encountered and chowned, use link(2) instead of chown(2). This is needed when the underlying storage (as it could be overlay with index=off) breaks the hard link on copy up. containers#1144 added the initial check. Closes: containers#1257 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jun 14, 2022
If the inode was already encountered and chowned, use link(2) instead of chown(2). This is needed when the underlying storage (as it could be overlay with index=off) breaks the hard link on copy up. containers#1144 added the initial check. Closes: containers#1257 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jun 14, 2022
If the inode was already encountered and chowned, use link(2) instead of chown(2). This is needed when the underlying storage (as it could be overlay with index=off) breaks the hard link on copy up. containers#1144 added the initial check. Closes: containers#1257 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jun 14, 2022
If the inode was already encountered and chowned, use link(2) instead of chown(2). This is needed when the underlying storage (as it could be overlay with index=off) breaks the hard link on copy up. containers#1144 added the initial check. Closes: containers#1257 Signed-off-by: Giuseppe Scrivano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure the same inode is not chowned twice. Track all the inodes that are chowned and skip the same inode if it is encountered multiple times.
Closes: #1143
Signed-off-by: Giuseppe Scrivano [email protected]