networking: lookup child IP in networks #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
giuseppe
force-pushed
the
set-source-to-net
branch
from
2a09d73 to
7b4a844
Compare
|
LGTM |
|
/lgtm |
|
Tests red |
|
LGTM |
edsantiago
reviewed
Jan 22, 2021
test/system/500-networking.bats
Outdated
| # This is the truly important check: make sure the remote IP is | ||
| # in the 172.X range, not 127.X. | ||
| is "$output" \ | ||
| ".*connect to \[::ffff:10\..*\]:$myport from \[::ffff:10\..*\]:.*" \ |
There was a problem hiding this comment.
You may want to s/:10/:172/g
giuseppe
force-pushed
the
set-source-to-net
branch
from
7b4a844 to
ca5450c
Compare
giuseppe
force-pushed
the
set-source-to-net
branch
2 times, most recently
from
6fdb62a to
1c496dc
Compare
if a CNI network is added to the container, use the IP address in that network instead of hard-coding the slirp4netns default. commit 5e65f0b introduced this regression. Closes: containers#9065 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
set-source-to-net
branch
from
1c496dc to
0ba1942
Compare
|
tests are green |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a CNI network is added to the container, use the IP address in that
network instead of hard-coding the slirp4netns default.
commit 5e65f0b introduced this
regression.
Closes: #9065
Signed-off-by: Giuseppe Scrivano [email protected]