Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Testing https://github.com/containers/image/pull/2636 #24629

Closed
wants to merge 2 commits into from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Nov 20, 2024

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Nov 20, 2024
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

The Go RPM is too old

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 20, 2024

For transparency, note the “HACK DO NOT MERGE: Skip testing on F40” commit.

@Luap99
Copy link
Member

Luap99 commented Nov 21, 2024

@mtrmac We cannot bump go versions so aggressively, should we add fedora -1 tests to c/common,image,storage to prevent bumps that cannot be build later down in the stack?

I have hopes that this specific instance may get fixed with sigstore/sigstore#1878 but then again any dependency can introduce a bump so I feel like we must guard against that early

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 21, 2024

@Luap99 Yes, this is now a problem.

Historically, the Go patch version bumps typically included a vulnerability fix, which meant that Fedora would update quickly. That hasn’t now been the case in Go 1.22.{7,8}.

I don’t feel strongly about automation forcing us to build on Fedora N-1. On the one hand, it would certainly prevent inconvenience like this, OTOH it might delay us from making updates (e.g. updates of dependencies fixing vulnerabilities) until a Fedora Go RPM lands in the stable stream.

Let’s see how the sigstore PR fares; in the worst case we can downgrade the sigstore dependency in c/image (and others?) at the last moment, on a short notice.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 26, 2024

The c/image PR was merged.

@mtrmac mtrmac closed this Nov 26, 2024
@mtrmac mtrmac deleted the only-one-config branch November 26, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants