Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 330-corrupt-images.bats for composefs behavior change #24314

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 18, 2024

With containers/storage#2118 and containers/image#2589 , the convert_images (i.e. “disallow non-partial pulls”) option fails with VFS.

The 330-corrupt-images tests were temporarily switching to VFS, possibly within a composefs test run with convert_images set, without disabling it. That is going to fail after we update c/image and c/storage; update the tests for the changed behavior.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2024
@mtrmac mtrmac force-pushed the composefs-enforcing-vfs branch from a52e79f to 50da568 Compare October 18, 2024 20:15
@mtrmac mtrmac force-pushed the composefs-enforcing-vfs branch from 17685d1 to fdc9fee Compare October 18, 2024 21:44
@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 18, 2024

@edsantiago This is a composefs feature/change change, not quite zstd:chunked related, so filing in a separate PR. And this test update will be necessary to support current c/storage + c/image even if we don’t switch to chunked images.

50da568 shows tests failing with current c/storage + c/image and no other modification.

17685d1 shows the tests passing with current c/storage + c/image, and a test update.

This PR now contains only the test update, as proven by the two test runs above.

@mtrmac mtrmac changed the title WIP: composefs enforcing vs. VFS test Fix 330-corrupt-images.bats in composefs test runs Oct 18, 2024
@mtrmac mtrmac marked this pull request as ready for review October 18, 2024 21:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@mtrmac mtrmac changed the title Fix 330-corrupt-images.bats in composefs test runs Update 330-corrupt-images.bats for composefs behavior change Oct 18, 2024
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99, mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,giuseppe,mtrmac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1ca42f0 into containers:main Oct 21, 2024
54 checks passed
@mtrmac mtrmac deleted the composefs-enforcing-vfs branch October 21, 2024 10:58
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 20, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants