-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 330-corrupt-images.bats for composefs behavior change #24314
Update 330-corrupt-images.bats for composefs behavior change #24314
Conversation
a52e79f
to
50da568
Compare
Signed-off-by: Miloslav Trmač <[email protected]>
17685d1
to
fdc9fee
Compare
@edsantiago This is a composefs feature/change change, not quite zstd:chunked related, so filing in a separate PR. And this test update will be necessary to support current c/storage + c/image even if we don’t switch to chunked images. 50da568 shows tests failing with current c/storage + c/image and no other modification. 17685d1 shows the tests passing with current c/storage + c/image, and a test update. This PR now contains only the test update, as proven by the two test runs above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With containers/storage#2118 and containers/image#2589 , the
convert_images
(i.e. “disallow non-partial pulls”) option fails with VFS.The 330-corrupt-images tests were temporarily switching to VFS, possibly within a composefs test run with
convert_images
set, without disabling it. That is going to fail after we update c/image and c/storage; update the tests for the changed behavior.Does this PR introduce a user-facing change?