Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to actions/stale@v3 #10357

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

srcshelton
Copy link
Contributor

Try more recent stale release… as currently with v1, remove-stale-when-updated is set but isn't causing labels to be updated when comments are added.

Relates to: #9258 (comment)

@srcshelton srcshelton changed the title Update to actions/stable@v3 Update to actions/stale@v3 May 16, 2021
@mheon
Copy link
Member

mheon commented May 16, 2021

Needs a signoff - can you git commit --amend -s and re-push?

@mheon
Copy link
Member

mheon commented May 16, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, srcshelton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2021
@srcshelton
Copy link
Contributor Author

Needs a signoff - can you git commit --amend -s and re-push?

Good question - since it's a one-character change, I made it through the GitHub web-UI rather than manually… did I miss a tick-box somewhere to sign-off the commit, or can you not do this via the UI?

I'll try to pull and amend locally...

… as currently with `v1`, `remove-stale-when-updated` is set but isn't causing labels to be updated when comments are added.

Signed-off-by: Stuart Shelton <[email protected]>
@srcshelton
Copy link
Contributor Author

Needs a signoff - can you git commit --amend -s and re-push?

Good question - since it's a one-character change, I made it through the GitHub web-UI rather than manually… did I miss a tick-box somewhere to sign-off the commit, or can you not do this via the UI?

I'll try to pull and amend locally...

Should be fixed, hopefully...

@mheon
Copy link
Member

mheon commented May 16, 2021

CI is green, you're good. @containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented May 16, 2021

LGTM, for the record

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@vrothberg
Copy link
Member

Thanks!

@openshift-merge-robot openshift-merge-robot merged commit 3bdbe3c into containers:master May 17, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants