Allow providing custom in_pod argument as a global compose file variable #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokibit
force-pushed
the
set-custom-in_pod-in-compose-file
branch
10 times, most recently
from
da4641a to
239cb05
Compare
mokibit
force-pushed
the
set-custom-in_pod-in-compose-file
branch
2 times, most recently
from
a7c084d to
d6e3316
Compare
This was referenced Jun 19, 2024
|
I forgot how any of this works but shouldn't this be a per-container setting? |
Pod is grouping of containers. At least currently all services in compose file are put in a single pod if this is enabled. Is there use case when some containers are put in a pod and the rest aren't? |
p12tic
reviewed
Jun 20, 2024
mokibit
force-pushed
the
set-custom-in_pod-in-compose-file
branch
from
d6e3316 to
ba2beb2
Compare
Default command line argument `in_pod` was set to True, but this breaks the compose file for users who want to use `--userns` argument. This commit sets default `in_pod` value to None, and later resolves whether to create a pod by checking compose file, as new argument in compose file x-podman is now available. Now it is convenient for users to pass custom `in_pod` value (True or False) as a compose file argument when command line value of `in_pod` is not provided. Signed-off-by: Monika Kairaityte <[email protected]>
mokibit
force-pushed
the
set-custom-in_pod-in-compose-file
branch
from
ba2beb2 to
360b85b
Compare
p12tic
approved these changes
Jun 20, 2024
p12tic
added a commit
to wgnathanael/podman-compose
that referenced
this pull request
Jun 22, 2024
…ompose-file Allow providing custom in_pod argument as a global compose file variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default command line argument
in_podwas set to True, but this breaks the compose file for users who want to use--usernsargument.This PR sets default
in_podvalue to None, and later resolves whether to create a pod by checking compose file, as new argument in compose file x-podman is now available (documentation is updated and tests added).Now it is convenient for users to pass custom
in_podvalue (True or False) as a compose file argument when command line value ofin_podis not provided.This PR solves issues: #795, #935, #673, #695, #166.