-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint fixes and enhancements #779
Lint fixes and enhancements #779
Conversation
8e6bc3e
to
ec4b9ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
In the documentation, please keep line length to around 100 chars or less.
The unit tests have migrated from pylint to unittest, so these changes are probably no longer relevant.
I understand a lot of time have passed, so you probably won't have time to go back to the PR. Maybe someone else can use the review to help extract useful stuff from the PR.
Signed-off-by: Jean-Baptiste Perez <[email protected]>
The initial link was related to GPG signature in commits (--gpg-sign or -S git-commit option) as the required signature is actually a "Signed-off-by" trailer at the end of the commit message (--signoff or -s git-commit option). Signed-off-by: Jean-Baptiste Perez <[email protected]>
Signed-off-by: Jean-Baptiste Perez <[email protected]>
Signed-off-by: Jean-Baptiste Perez <[email protected]>
ec4b9ea
to
81d81fb
Compare
Done.
I removed outdated fixes, rebased my branch onto However, the pytest to unitest and ruff migrations look not to be completed and I think |
Thanks, indeed.. |
A couple of modifications:
pytests/common.py
file),Lint fixing commits are independents.
As I added the
pytests/common.py
source file to factorise some duplicated code, thepre-commit run --all-files
command starts require an initial call toexport PYTHONPATH=$PWD
where$PWD
is the root directory of the repository.Is really
# pylint: disable=import-error
a correct way to handle this kind of issue?I did not find a proper and portable way to solve this problem directly in
.pylintrc
, but I'm open to suggestions.