Stop other containers when --abort-on-container-exit is used #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer-exit is enabled Signed-off-by: Jaikiran Pai <[email protected]>
jaikiran
force-pushed
the
abort-on-container-exit
branch
from
3c5a934 to
66a3ef6
Compare
|
Any thoughts about this change? |
|
I'm considering moving to python3's builtin asyncio and drop all threads if possible. I need some time to look into this change. |
|
Thank you @muayyad-alsadi. Please take your time. Looking forward to your changes and will test them out with our project when they are ready. |
|
Hi @jaikiran and @muayyad-alsadi. Thank you for working on this feature! Is there any update on this issue? I've run into the error which pertains to this MR and Podman support for the |
|
@muayyad-alsadi I have an PR for moving to asyncio that fixes this issue as well #810 |
|
Closing, now that the asyncio approach has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman-compose up, likedocker-composeprovides a--abort-on-container-exitoption to stop the containers that were launched by theupcommand when any of the other containers exit. In its current form in thedevelbranch, this isn't functional and the other containers keep running. This is also reported as an issue here #679.The commit in this PR adds this missing behaviour. I've tested this against one of the projects that I am using
podman-composein. Plus, I've also verified the trivial example that the reporter in #679 provided and it now stops the rest of the containers.