Throw a readable error on too old Python #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokibit
force-pushed
the
inform-user-to-use-newer-python
branch
3 times, most recently
from
7943b10 to
7fdbbd8
Compare
mokibit
force-pushed
the
inform-user-to-use-newer-python
branch
from
7fdbbd8 to
38d85eb
Compare
mokibit
changed the title
mokibit
force-pushed
the
inform-user-to-use-newer-python
branch
from
38d85eb to
5199c22
Compare
podman-compose v1.0.6 is the last to support Python3.6. When newer podman-compose version is used with too old Python, podman-compose gives only a confusing error. This commit gives a clear message to use upgraded Python version. A descriptive error can not be thrown, as line "from __future__ imports" must occur at the beginning of the file, but older Python (older than Python3.7) does not recognize __future__ and throws an error immediately. Therefore, a comment is used to inform the user to update his Python version. Signed-off-by: Monika Kairaityte <[email protected]>
mokibit
force-pushed
the
inform-user-to-use-newer-python
branch
from
5199c22 to
bdb3e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman-compose v1.0.6 is the last to support Python3.6. When newer podman-compose version is used with too old Python, podman-compose gives only a confusing error. This commit gives a clear message to use upgraded Python version.
A descriptive error can not be thrown, as line "from future imports" must occur at the beginning of the file, but older Python (older than Python3.7) does not recognize future and throws an errorimmediately.
Therefore, a comment is used to inform the user to update his Python version.
Fixes #982.