Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump c/storage to v1.56.0, c/image to v5.33.0 #2625

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

TomSweeneyRedHat
Copy link
Member

Bumping c/image to v5.33.0 after vendoring c/storage v1.56.0

This is in preparation for Podman v5.3

Bumping c/storage to v1.56.0 as part of the SIC vendor dance
for Podman v5.3.0

Signed-off-by: tomsweeneyredhat <[email protected]>
Bump to c/image v5.33.0 in preparation for Podman v5.3

Signed-off-by: tomsweeneyredhat <[email protected]>
Bump c/image back to a dev version, v5.34.0-dev

Signed-off-by: tomsweeneyredhat <[email protected]>
@TomSweeneyRedHat
Copy link
Member Author

I had all kinds of trouble getting this piece of the dance to work. I had to upgrade my build machine in order to get a high enough version of go, and then after vendoring only the go.* files changed. I'm assuming due to others having pulled from the top of tree recently?

@Luap99
Copy link
Member

Luap99 commented Nov 8, 2024

There is no vendor dir here so it is expected that only go.{mod,sum} change.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
change seems to match #2623

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lsm5 lsm5 merged commit 50fc527 into containers:main Nov 8, 2024
10 checks passed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/v5.33.0 branch November 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants