Use a pointer receiver for internal/set.Set #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to make sure that, and clear to callers that, Add() and Delete() modify the original object and not a copy. Luckily(?), this has worked fine, because Set contains a map[], which is a reference type, so a copy of Set just creates another reference to the same map. Either way, fix the method receivers, and add tests to ensure the code works as expected. Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to make sure that, and clear to callers that,
Add()andDelete()modify the original object and not a copy.Luckily(?), this has worked fine, because
Setcontains amap[], which is a reference type, so a copy ofSetjust creates another reference to the samemap.Either way, fix the method receivers, and add tests to ensure the code works as expected.