[release-5.24] Backport retries heuristics updates #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purely aesthetic, should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
... because we will have more cases of the NaN case, so share that code path. Signed-off-by: Miloslav Trmač <[email protected]>
Avoid redundant work. Signed-off-by: Miloslav Trmač <[email protected]>
Consistently use ms... for milliseconds (durations), and ...Time for timestamps. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
This will be used for more heuristics. Signed-off-by: Miloslav Trmač <[email protected]>
Even if we didn't make much progress, allow one retry per minute anyway. Notably this allows one retry ~immediately, we see failures a few dozen milliseconds after the connection is set up. Signed-off-by: Miloslav Trmač <[email protected]>
…d offset Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
Doh. Signed-off-by: Miloslav Trmač <[email protected]>
- Relax retry heuristics Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
|
/lgtm |
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
… so that CRI-O can vendor the latest version of the heuristics while remaining on the 5.24 stable branch.
Cc: @vrothberg @umohnani8