Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run codespell on codebase #1841

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Run codespell on codebase #1841

merged 1 commit into from
Feb 9, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 9, 2023

Signed-off-by: Daniel J Walsh [email protected]

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One possible discussion point, but I don’t feel strongly about it; feel free to merge as is.

// path-component := alpha-numeric [separator alpha-numeric]*
// alpha-numeric := /[a-z0-9]+/
// path-component := alphanumeric [separator alphanumeric]*
// alphanumeric := /[a-z0-9]+/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a bit attractive to keep this in sync with distribution/distribution/reference.

OTOH we’ve been drifting away quite a bit in the last few months, so that’s non-blocking.

@rhatdan rhatdan merged commit ab7be2f into containers:main Feb 9, 2023
@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants