Migrate from ghodss/yaml to gopkg.in/yaml.v3 #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires us to _manually_ deal with the bytes-as-base64-strings format. Signed-off-by: Miloslav Trmač <[email protected]>
This has insufficient unit test coverage... Signed-off-by: Miloslav Trmač <[email protected]>
|
Nice LGTM. |
|
Looks like vendoring is still pulling in |
|
@rhatdan, it's gone. The |
|
It is listed in go.mod above? |
|
How could I have missed that, apologies. |
|
|
Yes; the PR description mentions this dependency. We are getting rid of |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to remove a dependency on yaml.v2 which we, sort of, control. This parallels containers/skopeo#1885 .
At the very least this will allow removing
ghodss/yamlfrom Skopeo (but not from Podman, because Podman uses this package directly). That’s at least a bit of code.Note that the whole of c/image will continue to depend on
yaml.v2, via a Swagger-generated Rekor client, depending on go-openapi/runtime#245 .Tested, so far, only using unit tests; that suggests that the migration from
ghodss/yamlmight be fairly tricky. Theopenshiftcase is one where we would be quite unlikely to notice breakage in practice, but it has fairly good unit tests. Theregistries.dcase has worse unit tests, but simpler data types and probably better integration test coverage.