-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload and Download tests against vfkit #453
Upload and Download tests against vfkit #453
Conversation
62f231d
to
730f708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just a suggestion to reduce duplicate code
730f708
to
8e45dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasgun the test never deletes the temp files/dirs that it creates
09652f1
to
8e45dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In current state test not testing what it intend, see comment for for
loop
I prefer to have this test wrapped with Describe
with some cleanup code in AfterEach
. As multiple test runs will easily overflow laptop ssd.
If you are looking on samples how to doit, see https://onsi.github.io/ginkgo/#spec-cleanup-aftereach-and-defercleanup
FYI: I try to run test with fixed loop and it fail, VM crushed, not sure why
But this test is doing good job to indicate problems
8e45dda
to
909b24b
Compare
This commit adds two tests: 1. Upload files to the VM This test uploads three files of different sizes (10M, 100M, 1G) to the running VM and verifies the sha256sum of the uploaded files. 2. Download the above files from the VM This test downloads the three files uploaded in the previous test and verifies their sha256sum values. Signed-off-by: Gunjan Vyas <[email protected]>
909b24b
to
0b09d74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vyasgun 🚀
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evidolob, lstocchi, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This pull request adds two tests:
Upload files to the VM This test uploads three files of different sizes (10M, 100M, 1G) to the running VM and verifies the sha256sum of the uploaded files.
Download the above files from the VM This test downloads the three files uploaded in the previous test and verifies their sha256sum values.