[CI:DOCS] Github-workflow: Report both failures and errors. #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
woopsie...hold up a sec, there's a syntax error I thought I fixed (but obviously didn't)... |
Port of changes from containers/podman#12997 and containers/podman#13005 to the workflow in this repository. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
notify_on_error
branch
from
306f036 to
34bc00a
Compare
|
...okay, fixed and rebased. This PR was missing fix in containers/podman#13005 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Manually triggered test run: https://github.com/containers/buildah/actions/runs/1751867992 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Port of changes from containers/podman#12997 and
containers/podman#13005 to the workflow in this
repository.
How to verify it
Impractical to automatically verify, other than stare at it and wonder how it ever worked 🤣
TBH, I was able to test/confirm these changes via a similar PR in another repository:
https://github.com/containers/automation_images/runs/4940937282?check_suite_focus=true
(i.e. it correctly sent an error-notice e-mail due to an unrelated/soon-to-be-fixed problem)
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None