Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPdate vendor of container/storage #3641

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Nov 19, 2021

Signed-off-by: Daniel J Walsh [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@TomSweeneyRedHat
Copy link
Member

LGTM

@nalind
Copy link
Member

nalind commented Nov 19, 2021

Can you describe the motivation for going to an non-release version of the storage library?

@rhatdan
Copy link
Member Author

rhatdan commented Nov 20, 2021

Just want to run it through the CI/CD systems and make sure no breakage is sneaking in, like we found in Podman.

@rhatdan
Copy link
Member Author

rhatdan commented Nov 20, 2021

But if you want to cut a release, I am all for that as well.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2021
@flouthoc
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants