Fix UnsetEnv for buildah bud

[rhatdan]

Signed-off-by: Daniel J Walsh [email protected]

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flouthoc]

LGTM. @rhatdan could you rebase. I clicked on github UI rebase and its adding another commit to the PR.

[flouthoc]

This is not a blocker.
One doubt which i have is that its only modifying oci spec but not the actual image. But I'll check previous original PR to confirm.

@nalind PTAL

[rhatdan]

@nalind @giuseppe @vrothberg PTAL

[nalind]

Can we add a check that ensures two builds with --layers, one with a --unsetenv and one without, produce different images, i.e., that one doesn't get mistakenly used as the cached result of the other?

[nalind]

/lgtm