libcni: always delete the cache on conflist for CNI DEL #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the call with `DelNetwork`, and allows CRIO tests to bump - [0]. [0] - cri-o/cri-o#8207 (comment) Signed-off-by: Miguel Duarte Barroso <[email protected]>
aojea
reviewed
May 27, 2024
| if cachedResult != nil { | ||
| _ = c.cacheDel(list.Name, rt) | ||
| } | ||
| _ = c.cacheDel(list.Name, rt) |
There was a problem hiding this comment.
why should delete if there is no cachedResult?
There was a problem hiding this comment.
- the result is ignored; if there is no cached result, nothing bad will happen
- that is the same behavior as in
DelNetwork - it allows us to bump the ocicni library in crio to use the status verbs now.
The alternatives would be to stop checking the results in the cache in the crio tests (since the tests use CNI 0.3.1 ...) or to fix a lot of tests to use CNI version >= 0.4.0 .
This was discussed in the CNI maintainers meeting may 27th 2024, and seemed the simpler way forward, given it is totally innocuous.
There was a problem hiding this comment.
if maintainers approve 🤷 ... but it feels weird to change a library because some tests seems to be wrong ...
There was a problem hiding this comment.
squeed
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the call with
DelNetwork, and allows CRIO tests to bump - [0].[0] - cri-o/cri-o#8207 (comment)