Change CI's rustup version to use rust-toolchain.toml 's version #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-shim-protos
jokemanfire
force-pushed
the
test_fail
branch
2 times, most recently
from
bc06851 to
85b4821
Compare
and fix test's fail Signed-off-by: jokemanfire <[email protected]>
jokemanfire
force-pushed
the
test_fail
branch
from
85b4821 to
979a956
Compare
mxpv
reviewed
Feb 20, 2025
| - run: rustup toolchain install nightly --component rustfmt | ||
| - run: cargo +nightly fmt --all -- --check | ||
| # Remove the manual rustup nightly installation step | ||
| # - run: rustup toolchain install nightly --component rustfmt |
There was a problem hiding this comment.
Just remove these lines? We have git to take care of history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix test's fail. Ensure that the CI is consistent with the actual version of the rustup toolchain built.