fix the NRI_PLUGIN_NAME
env value when launching a pre-installed plugin
#42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable
NRI_PLUGIN_NAME
actually represents name in the pluginnri/pkg/stub/stub.go
Lines 273 to 280 in 8329599
nri/pkg/stub/stub.go
Lines 450 to 452 in 8329599
so if we pass
plugin name
(< idx >-< base name >
), the log will print out 'plugin name' with duplicateidx
.Note that there are some differences between the
plugin name
variable/field in plugin and adaptation.stub.name
stub.idx
stub.Name()
->stub.idx
+ "-" +stub.name