Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRunApparmor does not seem to ever run on the CI #3859

Closed
apostasie opened this issue Jan 31, 2025 · 3 comments · Fixed by #3860
Closed

TestRunApparmor does not seem to ever run on the CI #3859

apostasie opened this issue Jan 31, 2025 · 3 comments · Fixed by #3860
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim

Comments

@apostasie
Copy link
Contributor

Description

Rootful:
https://github.com/containerd/nerdctl/actions/runs/13000786746/job/36258878338?pr=3853#step:8:430

Rootless:
https://github.com/containerd/nerdctl/actions/runs/13000786746/job/36258878879?pr=3853#step:9:613

In both cases:

=== SKIP: cmd/nerdctl/container TestRunApparmor (0.00s)
    container_run_security_linux_test.go:176: needs to be able to apply "nerdctl-default" profile

I don't know why, and this does not make much sense.

Maybe for rootless - although https://github.com/containerd/nerdctl/blob/main/Dockerfile.d/test-integration-rootless.sh#L21 needs a serious review then - as it seems bizarre that a script named "-rootless" would do certain things when uid = 0.

For rootful though, we should certainly be able to load the profile and apply it.

This is related to #3858 : our current testing rig is hard to reason about, and more importantly, is hiding issues and non-running tests.

Steps to reproduce the issue

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Jan 31, 2025
@apostasie
Copy link
Contributor Author

apostasie commented Jan 31, 2025

Note: I do get what test-integration-rootless is doing.
It is just really hard to read for most people (and also does not seem to work as expected, as far as apparmor is concerned).

@apostasie
Copy link
Contributor Author

securityfs is not mounted.

@apostasie
Copy link
Contributor Author

Given the entrypoint is out of repository, I'll patch here, but maybe that should be ported to AkihiroSuda/containerized-systemd/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant