Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: should we drop testing inside a container? #3858

Open
apostasie opened this issue Jan 31, 2025 · 3 comments
Open

Discussion: should we drop testing inside a container? #3858

apostasie opened this issue Jan 31, 2025 · 3 comments

Comments

@apostasie
Copy link
Contributor

Our testing rig is designed around a container, and the CI itself is currently testing nerdctl purely inside a docker container.

This may be a good idea for server-side components that are also deployed and used inside containers.
It also may seem like a good idea to more easily "reproduce" specific target environments.

However, nerdctl is not a server component used in controlled environments. It's a cli, most of the time ran directly on (a variety of) hosts that we do not control.

It is very obvious that nobody is running the test suite directly on the host.
Because it fails. Despite recent efforts to fix it, it is still not passing on the most obvious and simplest environment of all: the default lima install.

Furthermore, by limiting developers' testing to that specific, artificially controlled container environment, we get a false sense of success, and tend to think that things are working, while really they are not.

I am suggesting that we stop encouraging testing inside the docker container, and instead that we re-design our testing to just run natively, and that we encourage contributors and users alike to test in their specific environment.

I am also suggesting that we remove the extra level of indirection on the CI if feasible.

Thoughts?

@AkihiroSuda
Copy link
Member

SGTM if the test env can be installed (and uninstalled) easily.

@apostasie
Copy link
Contributor Author

SGTM if the test env can be installed (and uninstalled) easily.

Ok.
I'll see what I can do.

@fahedouch
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants