This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Minor cleanup. #493
Merged
Minor cleanup. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanxuean
reviewed
Dec 13, 2017
pkg/server/sandbox_status_test.go
Outdated
|
|
||
| got := toCRISandboxStatus(sandbox.Metadata, state, createdAt, ip) | ||
| assert.Equal(t, expected, got) | ||
| func TestPodSandboxState(t *testing.T) { |
There was a problem hiding this comment.
Oops, forgot removing.
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
minor-cleanup
branch
from
42ea5d0 to
e4753ed
Compare
|
Apply LGTM based on #493 (review) |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
/cc @mikebrow @yanxuean
Signed-off-by: Lantao Liu [email protected]