Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

[release/1.4] Fix cleanup context of teardownPodNetwork #1641

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

adisky
Copy link
Contributor

@adisky adisky commented Jun 10, 2021

Cherry pick from commit

Co-authored-by: Quan Tian [email protected]

Signed-off-by: Aditi Sharma [email protected]

Co-authored-by: Quan Tian <[email protected]>

Signed-off-by: Aditi Sharma <[email protected]>
@k8s-ci-robot
Copy link

Hi @adisky. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adisky
Copy link
Contributor Author

adisky commented Jun 10, 2021

cc @dims

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims requested a review from mikebrow June 10, 2021 10:56
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@AkihiroSuda AkihiroSuda changed the title Fix cleanup context of teardownPodNetwork [release/1.4] Fix cleanup context of teardownPodNetwork Jun 19, 2021
@fuweid fuweid merged commit 3b02bec into containerd:release/1.4 Jun 19, 2021
@xh4n3
Copy link

xh4n3 commented Jun 21, 2021

@fuweid Hi~ do we have a plan for containerd 1.4.7 include this fix?

@mikebrow mikebrow added this to the next-candidate milestone Jun 21, 2021
@fuweid
Copy link
Member

fuweid commented Jun 22, 2021

@xh4n3 Sure, we do have plan, but we need to update vendor first. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants