Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nix): Fix install script for version > 2.23 #3067

Closed
wants to merge 1 commit into from
Closed

fix(nix): Fix install script for version > 2.23 #3067

wants to merge 1 commit into from

Conversation

BenoitKnecht
Copy link

Starting with nix 2.24, the binary is located under buildStatic.nix.x86_64-linux instead of buildStatic.x86_64-linux.

Without this commit:

ubuntu@125e8aa7e907:/$ install-tool nix 2.24
installing v2 tool nix v2.24
[13:40:49.461] INFO (87): Installing tool [email protected]...
Download failed: https://hydra.nixos.org/job/nix/maintenance-2.24/buildStatic.x86_64-linux/latest/download-by-type/file/binary-dist
Download failed, retrying
Download failed: https://hydra.nixos.org/job/nix/maintenance-2.24/buildStatic.x86_64-linux/latest/download-by-type/file/binary-dist
Download failed, retrying
Download failed: https://hydra.nixos.org/job/nix/maintenance-2.24/buildStatic.x86_64-linux/latest/download-by-type/file/binary-dist
Download failed: https://hydra.nixos.org/job/nix/maintenance-2.24/buildStatic.x86_64-linux/latest/download-by-type/file/binary-dist
[13:40:52.311] INFO (137): Downloading file ...
    url: "https://hydra.nixos.org/job/nix/maintenance-2.24/buildStatic.x86_64-linux/latest/download-by-type/file/binary-dist"
    output: "/tmp/50789f3416da6a7a362045e5add6d2ba81fef302b1678eae91ab63978e430317/binary-dist"
[13:40:52.589] ERROR (137): 
[13:40:52.590] FATAL (137): Download failed in 278ms.
[13:40:52.653] ERROR (87): Command failed with exit code 1: /usr/local/containerbase/bin/install-tool.sh nix 2.24
[13:40:52.653] FATAL (87): Install tool nix failed in 3.1s.

With this commit:

ubuntu@51abd3626c1e:/$ install-tool nix 2.24
installing v2 tool nix v2.24
[13:47:18.920] INFO (5): Installing tool [email protected]...
linking tool nix v2.24
nix (Nix) 2.24.1
[13:47:26.446] INFO (5): Install tool nix succeeded in 7.5s.

@BenoitKnecht
tools/v2/nix.sh: Fix install script for version > 2.23
7a4319f 
Starting with nix 2.24, the binary is located under
`buildStatic.nix.x86_64-linux` instead of `buildStatic.x86_64-linux`.

Signed-off-by: Benoît Knecht <[email protected]>
@BenoitKnecht BenoitKnecht mentioned this pull request Aug 6, 2024
Merged
@BenoitKnecht BenoitKnecht changed the title tools/v2/nix.sh: Fix install script for version > 2.23 fix(nix): Fix install script for version > 2.23 Aug 6, 2024
@BenoitKnecht
Copy link
Author

Closing as duplicate of #3066.

viceice
viceice approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this fix more than the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenoitKnecht @viceice