Add PHP 7.4 testing and dependency updates. #924
Conversation
|
I expect the "highest" tests to fail here, and others to pass. Help with compatibility with Symfony 4.4.x would be appreciated. |
|
The "lowest" tests are failing because I unpinned nikic/php-parser to make the newer dependency versions work, but this broke compatibility with older versions of php. Not super interested in spending a lot of time fixing the lowest test, but neither do I really want to make a new major version of Robo for PHP 7.4 just to drop PHP 7.1. If I did that, it would kill backporting PHP 7.4 support to the 1.x branch. |
|
Also, PackExtractCept is working for me locally with PHP 7,4; I'm not sure why this test is failing on Travis. |
| @@ -12,8 +12,11 @@ public function test(array $args, $options = | |||
| 'coverage' => false | |||
| ]) | |||
| { | |||
| $taskCodecept = $this->taskCodecept() | |||
| $collection = $this->collectionBuilder(); | |||
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
| $taskCodecept = $this->taskCodecept() | ||
| $collection = $this->collectionBuilder(); | ||
|
|
||
| $taskCodecept = $collection->taskCodecept() |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
RoboFile.php
Outdated
| ->args($args); | ||
| $taskPHPUnit = $collection->taskPHPUnit(); |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
|
Travis seems to be missing the zip extension in their PHP 7.4 container. |
| */ | ||
| public function mktmpdir($basedir = false) | ||
| { | ||
| $tempfile = tempnam($basedir ?: $this->testDir ?: sys_get_temp_dir(),'robo-tests'); |
There was a problem hiding this comment.
No space found after comma in function call
| foreach ($this->tmpDirs as $tmpDir) { | ||
| try { | ||
| $fs->remove($tmpDir); | ||
| } |
There was a problem hiding this comment.
Expected 1 space after closing brace; newline found
tests/functional/AssetsTest.php
Outdated
| public function testCssMinification() | ||
| { | ||
| if (version_compare(PHP_VERSION, '7.2.0') >= 0) { | ||
| $this->markTestSkipped('natxet/cssmin uses deprecated "each()" function (PHP 7.2+)'); |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 10
tests/functional/AssetsTest.php
Outdated
|
|
||
| $this->fixtures->createAndCdToSandbox(); | ||
|
|
||
| $sampleCss = $this->fixtures->dataFile('sample.css'); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
| $this->fixtures->createAndCdToSandbox(); | ||
|
|
||
| $sampleCss = $this->fixtures->dataFile('sample.css'); | ||
| $outputCss = 'minifiedSample.css'; |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
| $sampleCss = $this->fixtures->dataFile('sample.css'); | ||
| $outputCss = 'minifiedSample.css'; | ||
|
|
||
| $initialFileSize = filesize($sampleCss); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
|
|
||
| $initialFileSize = filesize($sampleCss); | ||
|
|
||
| $this->taskMinify($sampleCss) |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
| $initialFileSize = filesize($sampleCss); | ||
|
|
||
| $this->taskMinify($sampleCss) | ||
| ->to('minifiedSample.css') |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
|
|
||
| $this->taskMinify($sampleCss) | ||
| ->to('minifiedSample.css') | ||
| ->run(); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/AssetsTest.php
Outdated
| ->to('minifiedSample.css') | ||
| ->run(); | ||
|
|
||
| $this->assertFileExists($outputCss); |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
tests/functional/CleanDirTest.php
Outdated
| $this->assertFileExists('a.txt'); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The closing brace for the class must go on the next line after the body
tests/functional/ConcatTest.php
Outdated
|
|
||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The closing brace for the class must go on the next line after the body
tests/functional/DeleteDirTest.php
Outdated
| $this->assertFileNotExists('box/robo.txt'); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The closing brace for the class must go on the next line after the body
…dard does not allow our shortcut methods that begin with "_".
| $taskCodecept = $this->taskCodecept() | ||
| $collection = $this->collectionBuilder(); | ||
|
|
||
| $taskPHPUnit = $collection->taskPHPUnit(); |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 12 spaces, found 8
…r than "functional" tests
|
There are still a bunch of tests that need to be ported, but we'll start with this set. See advisory in CONTRIBUTING.md. |
Overview
This pull request:
Summary
Test with PHP 7.4 and latest dependencies.