Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only send internal coingecko error to sentry #1266

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

trkhoi
Copy link
Contributor

@trkhoi trkhoi commented Dec 4, 2023

What's this PR does ?

e.g: Update API get balances

Which UI commands affect by this change ?

e.g: /balances

DoD

  • Is it public API in documentation? Any docs update required ?
  • Does it change the response data shape ?
  • Is it require to update the mock data in preview ?
  • Include the sample call / example in this PR

@trkhoi trkhoi merged commit 206fced into develop Dec 4, 2023
@trkhoi trkhoi deleted the fix/only-send-internal-coingecko-error-to-sentry branch December 4, 2023 15:17
trkhoi added a commit that referenced this pull request Dec 6, 2023
* develop:
  fix: add chain type asset (#1269)
  Fix/handle context deadline exceeded (#1268)
  fix: add chain type (#1267)
  fix: only send internal coingecko error to sentry (#1266)
  fix: handle case vault not exist (#1265)
  fix: resolve crash (#1264)
  fix: rm wrong log
  fix: add more log service (#1263)
  fix: handle non supported wallet (#1262)
jphuc96 pushed a commit that referenced this pull request Dec 6, 2023
## [6.23.3](v6.23.2...v6.23.3) (2023-12-06)

### Bug Fixes

* add chain type ([#1267](#1267)) ([426ba32](426ba32))
* add chain type asset ([#1269](#1269)) ([75a115e](75a115e))
* add more log service ([#1263](#1263)) ([c5567ad](c5567ad))
* handle case vault not exist ([#1265](#1265)) ([38e0e0c](38e0e0c))
* handle non supported wallet ([#1262](#1262)) ([fef0443](fef0443))
* only send internal coingecko error to sentry ([#1266](#1266)) ([206fced](206fced))
* resolve crash ([#1264](#1264)) ([4e524a6](4e524a6))
* rm wrong log ([16b4813](16b4813))
@jphuc96
Copy link
Collaborator

jphuc96 commented Dec 6, 2023

🎉 This PR is included in version 6.23.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants