Upgrade libraries and licence year #154
Conversation
go.mod
Outdated
| go 1.21 | ||
| go 1.22 | ||
|
|
||
| toolchain go1.23.4 |
go.mod
Outdated
| @@ -1,29 +1,29 @@ | |||
| module connectrpc.com/vanguard | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
In newer versions of Go this is supposed to be a full version number. In previous releases just two components was sufficient.
There was a problem hiding this comment.
It's not that it's supposed to be a full version number -- simply that it is allowed to be. It's the toolchain directive that must be a full version number; this one can still be a language level. I'd prefer we stick with the language level so that things "just work" for users that disable the automatic download of Go toolchains.
There was a problem hiding this comment.
Why are we upgrading to v1.22.0? Our general policy is to support three versions of Go. We should stick with 1.21.0, and downgrade whatever dep requires 1.22.0, until we revisit this policy and change it across the ConnectRPC org (and possibly across bufbuild org, too).
We likely will need to change to supporting just the past two versions (like official Go SDK support policy) due to things like this:
googleapis/google-cloud-go@8a68e45#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
|
|
||
| require ( | ||
| buf.build/gen/go/connectrpc/eliza/connectrpc/go v1.11.1-20230822171018-8b8b971d6fde.1 | ||
| buf.build/gen/go/connectrpc/eliza/grpc/go v1.3.0-20230822171018-8b8b971d6fde.1 | ||
| buf.build/gen/go/connectrpc/eliza/protocolbuffers/go v1.31.0-20230822171018-8b8b971d6fde.1 | ||
| connectrpc.com/connect v1.16.2 | ||
| connectrpc.com/connect v1.18.1 |
There was a problem hiding this comment.
We should update buf.gen.yaml to use the same versions of plugins as the updated dependencies.
This upgrades the go dependencies and bumps the license year. Signed-off-by: Edward McFarlane <[email protected]>
Signed-off-by: Edward McFarlane <[email protected]>
Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/makeUpgrade
branch
from
64446d0 to
badf0c1
Compare
Signed-off-by: Edward McFarlane <[email protected]>
Signed-off-by: Edward McFarlane <[email protected]>
.github/dependabot.yml
Outdated
| - package-ecosystem: "gomod" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
There was a problem hiding this comment.
I don't think we need this. Let's stick with consistent configuration as the other connectrpc Go library repos.
Signed-off-by: Edward McFarlane <[email protected]>
This reverts commit 5b68e15. Signed-off-by: Edward McFarlane <[email protected]>
Signed-off-by: Edward McFarlane <[email protected]>
This upgrades the go dependencies and bumps the license year.