Correct typo in params.go #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @torkelrogstad , change looks good to me. You will need to sign your commits. Could you run git commit --amend --no-edit -s && git push -f
|
Done! |
|
@torkelrogstad, it looks like there may be some test assertions for the error message that now fail with the extra colon. You can run the tests locally using |
Signed-off-by: Torkel Rogstad <[email protected]>
|
Updated tests! They pass for me locally, let's see what CI says. |
jhump
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the error message returned looks like this:
invalid parameter \"date\" unsupported message type google.type.Date. Reads much better with the:added, IMO.