Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address style feedback #58

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Address style feedback #58

merged 2 commits into from
Jan 29, 2022

Conversation

akshayjshah
Copy link
Member

Address style feedback from #53. Ready for review any time; I'll keep pushing
fixup commits while it's open.

@akshayjshah
Rename ReceivedHeader -> {Request,Response}Header
fbf82c7 
Especially on user-facing types, use the familar request/response
terminology instead of sender/receiver.

See #53.
@akshayjshah akshayjshah requested a review from amckinney January 28, 2022 17:25
amckinney
amckinney approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these look good on their own so feel free to merge this one as-is and open up more PRs as follow-ups. Whatever you prefer.

@akshayjshah akshayjshah merged commit f2eb7fa into main Jan 29, 2022
@akshayjshah akshayjshah deleted the ajs/style branch January 29, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayjshah @amckinney