Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect GET support (server) #466

Merged
merged 15 commits into from
Mar 6, 2023
Merged

Connect GET support (server) #466

merged 15 commits into from
Mar 6, 2023

Conversation

jchadwick-buf
Copy link
Contributor

@jchadwick-buf jchadwick-buf commented Feb 17, 2023 •
edited
Loading

This is preliminary. It is split into parts:

  • Plumbing of idempotency level from schema to handlers
  • Implementation of method-based negotiation with Allow header
  • Support for GET requests in Connect protocol

Base automatically changed from stable-codec to get-support February 21, 2023 20:28
@jchadwick-buf jchadwick-buf marked this pull request as ready for review February 27, 2023 18:07
akshayjshah
akshayjshah reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Reviewed in person, expecting a few small changes and then it's good to land. Next step is adding support in clients too.

@jchadwick-buf
Copy link
Contributor Author

To make life easier, I split fixes out for each review item (except for one that was in the same logical unit as another) into its own commit and linked it, so that you can verify and resolve them individually with less effort.

akshayjshah
akshayjshah approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really appreciate the easy-to-review way you've put this PR together.

One small nit in an error message, but there's no need for substantive review after you fix it.

@jchadwick-buf jchadwick-buf merged commit af10789 into get-support Mar 6, 2023
@jchadwick-buf jchadwick-buf deleted the get-server branch March 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchadwick-buf @akshayjshah