Fix server-side timeout handling #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're parsing timeouts, but not properly propagating them into user code. Thanks, crosstests!
Since we know the shape of the Connect protocol, we can simplify the protocol interfaces and move some shared utility functions into `protocol.go`. This also fixes server-side timeout handling.
bufdev
approved these changes
May 13, 2022
doriable
approved these changes
May 13, 2022
We're only doing this at startup, so it's okay to make it slow. The code doesn't get much shorter, but it's arguably more readable.
Move the literal for our discard limit into a constant.
akshayjshah
added a commit
that referenced
this pull request
Jul 26, 2023
* Add test for unary RPC with zero-byte messages * Add failing test for handler timeout handling We're parsing timeouts, but not properly propagating them into user code. Thanks, crosstests! * Fix timeout handling Since we know the shape of the Connect protocol, we can simplify the protocol interfaces and move some shared utility functions into `protocol.go`. This also fixes server-side timeout handling. * Keep Accept-Post string manipulation shorter We're only doing this at startup, so it's okay to make it slow. The code doesn't get much shorter, but it's arguably more readable. * Add indirection to constant limit Move the literal for our discard limit into a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've defined the Connect protocol, we can simplify the protocol
interfaces: content-type negotiation is simpler, so the interface gets smaller.
This is also an easy moment to fix a bug in server-side timeout handling.