Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant line in the React example #764

Merged
merged 5 commits into from
May 16, 2024

Conversation

maksmas
Copy link
Contributor

@maksmas maksmas commented May 7, 2024

Remove redundant line in the example

Checklist

  • Documentation (if applicable)
  • Changelog

Copy link

cla-assistant bot commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@rkolesnev
Copy link
Contributor

Hi @maksmas - thanks for the cleanup PR.
Looking at the changes - i think the getPort() method is redundant as well. Could you remove it as well, please?

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev
Copy link
Contributor

Hey @maksmas - can you please update license header in the changed files to current year - for example

/*-
 * Copyright (C) 2020-2022 Confluent, Inc.
 */

to

/*-
 * Copyright (C) 2020-2024 Confluent, Inc.
 */

Both changed files need this - license is checked as part of build process - and it's currently failing on this check.

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev
Copy link
Contributor

/sem-approve

@rkolesnev rkolesnev merged commit 35a93e5 into confluentinc:master May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants