Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Simple retriable exception to remove error spam from logs #444

Merged
merged 61 commits into from
Oct 21, 2022

Conversation

astubbs
Copy link
Contributor

@astubbs astubbs commented Oct 19, 2022

Fixes #242

Checklist

  • Documentation (if applicable)
  • Changelog

Blocked by:

astubbs added 15 commits April 22, 2022 10:55
…xp/merge-retry

# Conflicts:
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/internal/BrokerPollSystem.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/internal/EpochAndRecordsMap.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/offsets/OffsetMapCodecManager.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/PartitionState.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/PartitionStateManager.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ProcessingShard.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/RemovedPartitionState.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ShardManager.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/WorkContainer.java
#	parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/WorkManager.java
#	parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/AbstractParallelEoSStreamProcessorTestBase.java
#	parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/offsets/OffsetEncodingBackPressureTest.java
#	parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/offsets/OffsetEncodingBackPressureUnitTest.java
#	parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/offsets/OffsetEncodingTests.java
#	parallel-consumer-core/src/test/java/io/confluent/parallelconsumer/state/WorkManagerTest.java
#	parallel-consumer-core/src/test/resources/logback-test.xml
@astubbs astubbs requested a review from rkolesnev October 20, 2022 17:41
@astubbs astubbs marked this pull request as ready for review October 20, 2022 18:01
…ption-simple

# Conflicts:
#	parallel-consumer-core/src/test-integration/java/io/confluent/parallelconsumer/integrationTests/state/PartitionStateCommittedOffsetIT.java
Copy link
Contributor

@rkolesnev rkolesnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of typos.

@astubbs astubbs merged commit 2ba47a3 into confluentinc:master Oct 21, 2022
@astubbs astubbs deleted the features/retry-exception-simple branch October 21, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let user function throw retry exception, instead of raw errors which pollute log
2 participants