Base class refactor - removes core api from extension modules #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astubbs
force-pushed
the
base-class-refactor
branch
from
506c88d to
e52ce5a
Compare
astubbs
force-pushed
the
base-class-refactor
branch
from
e52ce5a to
6e5f905
Compare
astubbs
added
breaking-change
enhancement
astubbs
changed the title
astubbs
force-pushed
the
base-class-refactor
branch
from
e7ecdff to
ab49ca5
Compare
astubbs
commented
Jul 28, 2021
...onsumer-vertx/src/test/java/io/confluent/parallelconsumer/vertx/VertxNonVertxOperations.java
Outdated
Show resolved
Hide resolved
astubbs
force-pushed
the
base-class-refactor
branch
from
d054670 to
cda5af8
Compare
astubbs
force-pushed
the
base-class-refactor
branch
from
cda5af8 to
e46bf45
Compare
Prevents the extension modules from incorrectly inheriting core methods that would be broken to use. Step 1: new parent: rename
astubbs
force-pushed
the
base-class-refactor
branch
from
c46fb2a to
98eb42f
Compare
Remove deprecated test class
astubbs
force-pushed
the
base-class-refactor
branch
from
98eb42f to
01096c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #99 Completely remove non vertx operations from vertx implementation be refactoring out an abstract base class that Vert.x module can extend, instead of extending the core PC.
This is because the threading model is so different, it's totally invalid to call the core methods from the extension modules. There's also zero advantage in having them both available.