Fix to metadata refresh interruption #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
4f3b716 to
ced675f
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
3e05712 to
fc00cfc
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
ced675f to
74b82fc
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
fc00cfc to
420116d
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
74b82fc to
05c2830
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
420116d to
60045b7
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
05c2830 to
8090e71
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
60045b7 to
4657f99
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
2 times, most recently
from
bdccc8c to
f0d63ab
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
78a5434 to
31fea0e
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
2 times, most recently
from
f9b1fa7 to
7bfe82b
Compare
emasab
force-pushed
the
dev_fix_metadata_call_before_join_group
branch
from
31fea0e to
cbf2c54
Compare
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
7bfe82b to
e3bc31e
Compare
Base automatically changed from
dev_fix_metadata_call_before_join_group
to
dev_kip848
April 15, 2024 15:20
Metadata refreshes without partition leader change could lead to a loop of metadata calls at fixed intervals. Solved by stopping metadata refresh when all existing metadata is non-stale. Happening since 2.3.0
emasab
force-pushed
the
dev_fix_metadata_fast_refresh_loop
branch
from
e3bc31e to
44dc011
Compare
pranavrth
reviewed
Apr 15, 2024
| } | ||
| rd_kafka_mock_request_destroy_array(requests, request_cnt); | ||
| rd_usleep(100 * 1000, 0); | ||
| while (matching_request_cnt < expected_cnt) { |
There was a problem hiding this comment.
If this criteria is never met, the test will be in infinite loop. Can we make sure that there is some deterministic terminate condition?
pranavrth
approved these changes
Apr 15, 2024
emasab
added a commit
that referenced
this pull request
Apr 18, 2024
Metadata refreshes without partition leader change could lead to a loop of metadata calls at fixed intervals. Solved by stopping metadata refresh when all existing metadata is non-stale. Happening since 2.3.0
anchitj
pushed a commit
that referenced
this pull request
Jun 10, 2024
Metadata refreshes without partition leader change could lead to a loop of metadata calls at fixed intervals. Solved by stopping metadata refresh when all existing metadata is non-stale. Happening since 2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata refreshes without partition
leader change could lead to a loop of
metadata calls at fixed intervals.
Solved by stopping metadata refresh
when all existing metadata is non-stale.
Happening since 2.3.0
Closes #4577