Produce - KIP 467 - v8 #4583
Merged
Produce - KIP 467 - v8 #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchitj
force-pushed
the
dev_produce_kip_467_test
branch
7 times, most recently
from
daba407 to
c22ba01
Compare
anchitj
force-pushed
the
dev_produce_kip_467_test
branch
3 times, most recently
from
733f3c8 to
c90c919
Compare
anchitj
force-pushed
the
dev_produce_kip_467_test
branch
from
847ef5b to
1189944
Compare
anchitj
force-pushed
the
dev_produce_kip_467_test
branch
from
1189944 to
2e2091c
Compare
emasab
approved these changes
Apr 10, 2024
src/rdkafka_request.c
Outdated
| @@ -139,6 +139,7 @@ int rd_kafka_err_action(rd_kafka_broker_t *rkb, | |||
| case RD_KAFKA_RESP_ERR__TIMED_OUT: | |||
| case RD_KAFKA_RESP_ERR_REQUEST_TIMED_OUT: | |||
| case RD_KAFKA_RESP_ERR_NOT_ENOUGH_REPLICAS_AFTER_APPEND: | |||
| case RD_KAFKA_RESP_ERR_INVALID_MSG: | |||
There was a problem hiding this comment.
Move it down below after RD_KAFKA_RESP_ERR_NOT_ENOUGH_REPLICAS as we know for sure the batch wasn't persisted
tests/0011-produce_batch.c
Outdated
| rkmessages = calloc(sizeof(*rkmessages), msgcnt); | ||
| for (i = 0; i < msgcnt; i++) { | ||
| int *msgidp = malloc(sizeof(*msgidp)); | ||
| char *t; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record_errorsanderror_msgfields.RD_KAFKA_RESP_ERR_INVALID_MSGretriable.